Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugins to inherit from WorkerPlugin #1230

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Update plugins to inherit from WorkerPlugin #1230

merged 5 commits into from
Oct 4, 2023

Conversation

jrbourbeau
Copy link
Contributor

Upstream in distributed we're considering enforcing plugins to inherit from their respective base class (e.g. WorkerPlugin, SchedulerPlugin, NannyPlugin) dask/distributed#8149. This PR updates plugins here to inherhit from WorkerPlugin. This makes things a little more future-proof and is probably a good thing to do anyways.

@jrbourbeau jrbourbeau requested a review from a team as a code owner September 5, 2023 15:52
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 5, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the python python code needed label Sep 5, 2023
@jrbourbeau
Copy link
Contributor Author

cc @rjzamora @jacobtomlinson as this came up in a meeting earlier today

@rjzamora rjzamora added bug Something isn't working 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed improvement Improvement / enhancement to an existing function labels Sep 5, 2023
@rjzamora
Copy link
Member

rjzamora commented Sep 5, 2023

Thanks @jrbourbeau !

@jrbourbeau
Copy link
Contributor Author

Btw, I'm not super familiar with the codebase here. So just let me know if there are other plugins around

@wence-
Copy link
Contributor

wence- commented Sep 6, 2023

/ok to test

@wence-
Copy link
Contributor

wence- commented Sep 28, 2023

/ok to test

@pentschev pentschev changed the base branch from branch-23.10 to branch-23.12 October 4, 2023 06:00
@pentschev pentschev changed the base branch from branch-23.12 to branch-23.10 October 4, 2023 07:51
@pentschev pentschev requested a review from a team as a code owner October 4, 2023 07:51
@pentschev pentschev changed the base branch from branch-23.10 to branch-23.12 October 4, 2023 07:51
@pentschev
Copy link
Member

/ok to test

@pentschev
Copy link
Member

/ok to test

pentschev
pentschev approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jrbourbeau for helping us out with getting Dask-CUDA up-to-speed with latest Distributed changes!

@pentschev
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 38eec6c into rapidsai:branch-23.12 Oct 4, 2023
23 checks passed
@jrbourbeau jrbourbeau deleted the plugin-inherit branch October 4, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
dask-cuda
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrbourbeau @rjzamora @wence- @pentschev